On Mon, Dec 14, 2009 at 4:34 PM, Evan Stade <est...@chromium.org> wrote:
> I think adding a --disposition= field is overkill and will be harder to
> maintain (which is the worst part about command line flags). If a new
> disposition is added to webkit, one is renamed, or one is deleted, are you
> willing to either maintain this code or have users' desktop shortcuts break?
>
Given that I'm the one that created the dispositions in the first place,
yeah, I am.
CURRENT_TAB and NEW_BACKGROUND_TAB are pretty useful. The rest aren't, so
I'd only add those two alongside the two you mentioned.
I don't know why we have both SUPPRESS_OPEN and IGNORE_ACTION; I added the
first and Ojan added the second. At this point it looks like we only ever
set IGNORE_ACTION, and we only ever act on SUPPRESS_OPEN, so something is
really messed up.
PK
--
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
