I had talked with Linus about this earlier. I don't really understand the desire to have people looking on a list to figure out where to send a patch. Ideally, people would open a bug (or comment on an existing bug), or talk with someone in the IRC channel before going off and making a patch. There should be some communication first, during which it would become clear who could be listed as a reviewer. Directing people to a list of reviewers for specific areas encourages coding first without talking to the team. If someone not familiar with the team wants to submit a patch, great. They should talk to the team first (e.g. just shout out in #chromium-dev "Hey, I want to fix this, what do you think") and get directed to the appropriate people that way, rather than just silently emailing a patch to someone whose name is on a list.
-Ian 2008/9/11 Ben Goodger (Google) <[EMAIL PROTECTED]> > One idea is a review suggestion system built into or adjacent to > Rietveld. Basically committers can subscribe to specific files and > paths. They will then be suggested for review for changes that touch > those paths, and auto-CC'ed on the review even if they're not the > reviewer. This way you don't need to hunt around for reviewers - they > find you as soon as you touch code they know about. > > We just need someone to volunteer add this to Rietveld. (It's python, > django and app-engine). > > -Ben > > 2008/9/11 ph <[EMAIL PROTECTED]>: > > > > I often encounter a problem when finding reviewers, and have to ask > > who should review what. It's no problem for me, but maybe the process > > could be smoother if we had a page saying "build system -> contact (e- > > mail1), webkit/glue/ -> (e-mail2)" etc. Probably it won't cover all > > cases, but IMHO would be a nice addition. > > > > Paweł Hajdan jr > > > > > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---
