Hi Evan, On Wed, Sep 17, 2008 at 1:23 PM, Evan Martin <[EMAIL PROTECTED]> wrote:
> > On Wed, Sep 17, 2008 at 8:43 AM, Marshall Greenblatt > <[EMAIL PROTECTED]> wrote: > > This function is like DumpDocumentText() but returns the complete > document > > string (HTML, for instance) instead of just the text representation. > This > > function will facilitate the addition to the test_shell project of a > simple > > view page source implementation (similar to the "Dump body text..." > option > > that currently exists, but for the complete HTML). > > This description would be a great candidate for the comment before the > function prototype. > Right now you have two functions in a row with comments: > // Returns the text of the document element. > // Returns the string of the document element. > which are meaningless to me. A very good point. I'll make sure that the description is actually descriptive :-). > > I'm not sure who a good reviewer would be, sorry. :( That's OK, I can always bug the guys on IRC if nobody volunteers ;-). Regards, Marshall --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---
