Shall I first submit a bug so I can insert the right BUG=XXXXXX
line when I do a "gcl change mychange" ? Regards Gaetano Mendola On Sep 24, 6:55 pm, "Evan Martin" <[EMAIL PROTECTED]> wrote: > It sounds to me like you understand both the issues and how to resolve > them pretty well -- if you submitted a patch I'd be happy to find > someone to review it. > > Here's how to get started:http://dev.chromium.org/developers/contributing-code > > On Wed, Sep 24, 2008 at 3:37 AM, Gaetano Mendola <[EMAIL PROTECTED]> wrote: > > > File base/base_drop_target.cc > > > * members appear initialized in a different order than the .h > > specification > > * In BaseDropTarget::CTOR - the return value of RegisterDragDrop > > is discarded > > * In BaseDropTarget::DTOR - shouldn't be called RevokeDragDrop ? > > * BaseDropTarget::Release - > > Is the assignment ULONG copied_refcnt = > > ref_count_; correct ? > > Between the atomic decrement and the following > > assignment there is a time window > > in where ref_count can change. If the code is > > correct better to add a comment for future > > inspections. > > > File base/base_drag_source.cc > > > * BaseDragSource::Release - > > Same comment about BadeDropTarget::Release > > > Regards > > Gaetano Mendola --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---
