On Fri, Oct 10, 2008 at 3:50 PM, Ojan Vafai <[EMAIL PROTECTED]> wrote:
> I'd love to hear from people who disagree about these proposed policies so > we can compromise on something everyone is happy with. > I tend to think anybody should be able to do anything TBR if they have a good reason. "I'm fixing build bustage" is a good reason. "Whatever, I'm lazy" isn't. "Seeing the change in this DEPS file is not going to help you actually determine if it is safe" is arguably OK, although I'd almost rather people just check in without review at all for cases like that, as TBR implies "this should be reviewed, but can go in first" whereas the assertion we're sort of making there would be "this doesn't need review". If it doesn't, then why TBR? When I broke the build the other night, it wasn't TBRing that was the problem, but checking in when I wasn't going to have time to watch the tree. I dunno, I guess I don't share your need to write a hard rule on this. I think more people have screwed things up due to not watching the tree, not using the trybots, etc. than misuse of TBR. The only inconsistency I've really seen there was stuff like DEPS changes. PK --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---
