FYI, I just did this exercise with Mac and it's going to be a long road, mostly because PLATFORM(MAC) means so many different things, and we want some of that behavior but not all of it.
The CLs are at http://codereview.chromium.org/7477/show http://codereview.chromium.org/7478/show It's a total hack, but it's a starting place for a discussion with the webkit folks over how we seriously need to partition that one define into several for everyone's sanity. I think the end result is that we won't be able to turn this off on Mac for a long time, but at least we'll have a plan in place to get there. On Thu, Oct 16, 2008 at 8:29 PM, Darin Fisher <[EMAIL PROTECTED]> wrote: > FYI, I'm working to turn off PLATFORM(WIN) for the windows build now. There > are many hurdles in the way, so it may take me a few days to work it all > out. I think the Linux port will hit fewer of those hurdles since you don't > have to worry about full fidelity yet. > -Darin > > On Thu, Oct 16, 2008 at 5:04 PM, Evan Martin <[EMAIL PROTECTED]> wrote: >> >> Today we discussed the fate of PLATFORM(GTK) for Chromium's WebKit on >> Linux. >> We currently build WebKit with the GTK define on, but we concluded we >> should turn it off. >> >> There are calls in WebKit that, for example, want to bring up a >> file-picker dialog. Underneath the GTK platform, those call through >> to the GTK file picker. In our CHROMIUM platform for WebKit, they >> instead delegate to glue which can then proxy them back to the browser >> process. In those sorts of cases it's obvious that we want CHROMIUM >> and not GTK. >> >> What we discussed today is the leftover bits: those not covered by >> CHROMIUM but potentially by GTK (for example, font drawing). What I >> think we concluded was that any place that would call into GTK would >> likely need a connection to the X server (for example again, font >> drawing) and our renderers will not have that access. So it seems >> we'll be better off not setting PLATFORM(GTK) and instead using a >> mixture of CHROMIUM and whatever more unix-specific bits we can. >> (We'll still be linking to GTK for theme drawing.) >> >> What this means to people working on the port: don't mess around with >> code that is currently under PLATFORM(GTK) since we'll be turning it >> off. >> >> > > > > > -- Mike Pinkerton Mac Weenie [EMAIL PROTECTED] --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---
