OK, cool, thanks... This does answer my question now :-) The problem is that newbies are not realy sure what tests are actually applicable, though they are probably willing to wait an hour for the whole set of tests to run since they must get validation anyway, and it may take as long to get it as it takes to get the tests ran, especially when doing it from other time zones...
I think it would be worth it to have a script that allows us to at least run all the small tests. I'll see if I can do something there once I get more familiar with all this... BYE MAD 2008/11/22 Pam Greene <[EMAIL PROTECTED]> > > It's almost certainly in need of some maintenance, but there's a > smoketests.py script in > > > http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/test/smoketests.py?view=log > > When it's properly up to date, it runs any or all of the tests, using > the same command lines as the buildbot, skipping any whose data is not > available. > > But the reason that script isn't maintained is that as far as I know, > nobody uses it. In practice, I rather suspect that developers run at > most any unit tests that look directly applicable, and let the > buildbots run the rest for them. The tryserver can help here too. > Given that a full run of every test takes well over an hour, that's > understandable, if not theoretically ideal. > > - Pam > > On Sat, Nov 22, 2008 at 9:52 AM, Marc-André Decoste <[EMAIL PROTECTED]> > wrote: > > Thanks for the info. > > > > But I sitll wonder: > > How does an external developer identify the tests that CAN (and should) > be > > run before submitting a patch? > > > > BYE > > MAD > > 2008/11/22 Pam Greene <[EMAIL PROTECTED]> > >> > >> The long-term goal is to create new page-cycler data, through a > >> combination of research (what pages are representative?), mangling > >> (replacing data that we don't have permission to redistribute with > >> generic images and "lorem ipsum" text), and evangelism (asking page > >> owners for permission). In the meantime, there are a few tests that > >> can't be run externally, page-cyclers among them. > >> > >> (As an aside, the page-cycler is pretty far from a unit test in the > >> conventional sense of the phrase. The unit tests are mostly runnable; > >> the large-scale tests not as universally so.) > >> > >> - Pam > >> > >> On Sat, Nov 22, 2008 at 9:07 AM, Marc-André Decoste < > [EMAIL PROTECTED]> > >> wrote: > >> > So what are we expecting the external partner to do to run as many > unit > >> > test > >> > as possible and know which ones? > >> > > >> > Thanks! > >> > > >> > BYE > >> > MAD > >> > > >> > 2008/11/22 Marc-Antoine Ruel <[EMAIL PROTECTED]> > >> >> > >> >> [+chromium-dev] > >> >> > >> >> Please look at > >> >> > >> >> > >> >> > http://build.chromium.org/buildbot/waterfall/builders/Vista%20Perf/builds/1064/steps/page_cycler_moz/logs/stdio > >> >> > >> >> for an example use. > >> >> > >> >> On Sat, Nov 22, 2008 at 1:42 AM, Marc-Andre Decoste <[EMAIL PROTECTED]> > >> >> wrote: > >> >> > Salut, > >> >> > > >> >> > sorry if I missed something in the setup documentation, but > while > >> >> > I > >> >> > followed it the best I can, I'm not able to run some unit tests > >> >> > because > >> >> > the > >> >> > data folder isn't in my svn repository. > >> >> > > >> >> > For example, when I run the > src\chrome\Debug\page_cycler_tests.exe > >> >> > test, > >> >> > it looks for > >> >> > > >> >> > > >> >> > > file:///C:/src/chromium/src/data/page_cycler/moz/start.html?iterations=2&auto=1 > >> >> > and can't find it, there is to data folder under > c:/src/chromium/src. > >> >> > > >> >> > Did I miss anything? > >> >> > > >> >> > Thanks! > >> >> > > >> >> > BYE > >> >> > MAD > >> >> > >> >> > >> > > >> > > >> > > > >> > > >> > >> > > > > > > > > > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---
