On Thu, Dec 11, 2008 at 1:03 AM, John Abd-El-Malek <[EMAIL PROTECTED]> wrote: > On Thu, Dec 11, 2008 at 12:07 AM, e. roman <[EMAIL PROTECTED]> wrote: >> >> Glad to hear this. >> However I just tried building some webkit-merge changelists and >> rietveld continues to have problems. >> (upload would succeed, but when trying to load the resulting page you >> get a 500; 170 files total). > > I just saw this in the error logs. One of the Rietveld reviewers had > pointed out another place where we can reduce the lookups by O(n), and > I just pushed that. With that, I can see that issue (11377) fine.
oops, I meant 13377 > Can you try uploading again? It might be best to start from a new > issue (i.e. gcl delete and then create another changelist). > >> >> I ended up chunking into gcl changes of 40 each, but this is a pain to >> manage. >> Hopefully there is more improvement that can be made here... >> >> On Wed, Dec 10, 2008 at 4:03 PM, Erik Kay <[EMAIL PROTECTED]> wrote: >>> >>> Awesome John. Thanks! >>> >>> >>> On Wed, Dec 10, 2008 at 4:00 PM, John Abd-El-Malek <[EMAIL PROTECTED]> >>> wrote: >>>> >>>> (It's been suggested that I send this out to a large audience, so here you >>>> go) >>>> >>>> Most of the Rietveld problems that I see in the logs or that people >>>> complain about has been with regards to either very large changelists >>>> (i.e. > 100 files) or with many patchsets of large changelists (i.e. >>>> 10 patchsets of 20 files each). I've recently been pushing fixes to >>>> alleviate these problems, so Rietveld should now be able to work with >>>> these kinds of changelists. If you've been holding back using >>>> Rietveld for these reviews, or manually splitting them up into >>>> multiple changelists, this shouldn't be necessary anymore. >>>> >>>> Note that changelists with > 500 files still won't work. Those are >>>> pretty rare and it would take major changes to how Rietveld works in >>>> order to make them work, so I don't think it's worth it at this point. >>>> >>>> As usual, let me know if you see any problems. >>>> >>>> > >>>> >>> >>> > >>> >> >> >> >> > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---
