OK. I've just checked in a new linter. It now takes just a couple seconds to run. Evan, want to add it to the git-cl precommit hook? pinkerton (or anyone else), any interest in adding this to gcl. I go on vacation tomorrow, so I don't have time to get it in.
On Fri, Dec 12, 2008 at 5:12 AM, Mike Pinkerton <pinker...@chromium.org>wrote: > > The mac test buildbot was broken twice in the last 12 hours because of > changes that easily could have been identified by running the new lint > tool. > > Please try to remember to do this before checking in. I don't think we > want to make this a checkin hook, but if it keeps happening, we may > need to. > > On Wed, Dec 10, 2008 at 2:17 PM, Ojan Vafai <o...@chromium.org> wrote: > > > Firstly, there is now a lint option that will parse the test list for > each > > platform (win/mac/linux) and each build target (debug/release). This way > you > > can know that you at least got the syntax right. So, please consider > running > > this when you make test list changes. It takes ~30 seconds on my machine > and > > saves you from closing the tree. Also, if you feel moved to improve our > > tools a bit, add a pre-commit hook to gcl/git-cl to do this for us > > (please!). > > $ ./run_webkit_tests.sh --lint-test-files > > 081210 11:04:34 run_webkit_tests.py:142 INFO Found: 10244 tests > > 081210 11:04:59 run_webkit_tests.py:614 INFO SUCCESS > > -- > Mike Pinkerton > Mac Weenie > pinker...@google.com > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to chromium-dev@googlegroups.com To unsubscribe from this group, send email to chromium-dev+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---
