If you never look at log output from unit tests, you can skip this message.
I landed a change today that makes sure that InitLogging is called during startup of all of our unit tests that use test_suite (there are a small number of tests that don't). Prior to this, it would initialize on first use. This could lead to issues with threading when two threads tried to use logging for the first time (this was happening with base_unittests.exe). The new behavior means that a file handle will be opened immediately at launch where it wasn't before (this affected at least one test that expected no file handles to be opened when it ran). As part of this change, I also changed the default filename of all of the logs to be testname.log (e.g. base_unittests.log). Perf unit tests have two log files, testname.log and testname_perf.log (e.g. perf_tests.log and perf_tests_perf.log). All unit test initialization is now handled in one place (base/test_suite.h) rather than scattered in each unit test. If you want to change what happens during test initialization, change it here or in one of its subclasses. There are no command-line flags that affect the behavior of this general logging code. Prior to this, some tests had their own custom flags. If you find yourself missing one of these flags, add them back here so that all tests can benefit. Erik --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
