On Wed, Jan 14, 2009 at 9:28 PM, Brett Wilson <[email protected]> wrote: > I'm on the fence about this builder class since it somehow feels like > overkill for this application.
I intend to update the existing switch-appending functions so it will hopefully be about the same amount of code as before (which uses a collection of static functions within the CommandLine class). > If we do go with the class, do we really need a vector of strings? It > seems like every use (though I haven't looked at all uses) is > basically. > have a string > append some switches > use the string > so that keeping the vector of strings is just a lot of mallocs and > string copies with no purpose. > > Now that I write this, I think having the class is fine since it > provides some useful scoping for these things, but I think it should > just keep a string and append to it like we do currently. The reason I'm looking at this is that when using the command line, the exec family of functions work with an argv array, not a quoted string. --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
