When you #ifdef around some code to make things temporarily link, but
know that you'll need to bring that code (or its functional
equivalent) back at some point, please mark those points carefully. I
fear that we'll eventually have everything building and linking
together at some point and it'll crash and there will be 30,000 #ifdef
OS_WIN where 20 of them were temporary hacks.
Here's the pattern I use:
#if defined(OS_WIN)
// code as before
#else
// TODO(port): <explanation of what is wrong with the above>
NOTIMPLEMENTED(); // so you get a run time error message rather
than mystery crash
#endif
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
