I like pulling the structures out of public view. Altering ReadWebPlugInfo sounds reasonable, but it's called by code outside plugin_lib, so callers have to deal with two things coming back (a WebPluginInfo and a pointer set). If you can do it cleanly, it sounds good.
Avi On Tue, Jan 20, 2009 at 1:48 PM, John Abd-El-Malek <[email protected]> wrote: > It seems that the only reason this code is needed is to get the function > pointers for the internal plugin. Perhaps the PluginVersionInfo & > InternalPluginInfo stuff could be taken out of the platform independent > code. ReadWebPluginInfo can be modified to return both the WebPluginInfo & > the three function pointers (if it's an internal plugin). What do you > think? > > On Tue, Jan 20, 2009 at 9:33 AM, Avi Drissman <[email protected]> wrote: > >> I'm looking at InternalPluginInfo in plugin_lib.h. Its first component is >> a PluginVersionInfo, which is basically the Win32 version of the NPAPI data. >> Right now my plugin info parsing code pulls info from either a plist (via >> CFBundle) or resources, and neither is easy to reuse to parse a set of >> strings. What format does Linux have? Could we reuse the code? >> >> Avi >> >> >> >> > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
