Oops, it seems like my 'Replace All' failed. You are right that the files you listed aren't used. We plan to reduce our dependency on WTL so I don't think it matters at all.
I did the initial check-in. I don't recall patching the 3 files you listed. M-A On Fri, Jan 23, 2009 at 11:12 AM, noemata <[email protected]> wrote: > > A patch was applied to the chromium copy of WTL, however the following > item was missed. It's likey this has not been noticed because this > file might not be used by any project. > > atlctrlx.H > > Line 997 > > int cyMax = __max(rcLeft.bottom, max(rcLink.bottom, rcRight.bottom)); > > // second ref to max breaks NOMINMAX > > Line 4191 > > nMenuItemsCount = __min(min(nPageCount, nMenuItemsCount), (int) > m_nMenuItemsMax); > > // second ref to min breaks NOMINMAX > > Also, I was not able to resolve where the other patches to WTL came > from. The docs only make reference to the min/max patch, yet these > files have beeen patched also: > > atldlgs.h > atluser.h > atlwince.h > > > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
