Great. I think I could update
http://dev.chromium.org/developers/contributing-code to contain these
points. What do you think?
On Wed, Jan 28, 2009 at 07:04, Brett Wilson <bre...@chromium.org> wrote:
> 1. When a patch author requests more than one reviewer, they should
> make clear in the review request email what they expect the
> responsibility of each reviewer to be. Example:
> agl: bitmap changes
> evanm: process hacks
> everybody else: FYI
>
> 3. The author should wait for approval from everybody on the reviewer
> list before checking in.
>
> 5. If you're on "FYI" person on a review and you didn't actually
> review in detail (or at all), but don't have a problem with the patch,
> note this. You could say something like "rubber stamp" or "ACK"
> instead of "LGTM."
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
