On the Mac, I think we want to match Apple WebKit baselines.  I don't
know if there are any baselines currently in chromium-win that we
should share.

Mark

Dean wrote:
> I talked to Mads a bit, basically:
>
> 1) I think the Mac expected result fallback is currently wrong, it
> doesn't seem to look in chromium-win correctly.  This is probably
> causing a lot of failures.
>
> 2) We should move chromium-win to chromium (or chromium-common), and
> then chromium-win should not be a fallback.  This might be more
> confusing to manage, but it's also less confusing to understand that
> everything should / can fallback to the Windows expectations.
>
> On Thu, Jan 29, 2009 at 2:49 PM, Mads Sig Ager <[email protected]> wrote:
>>
>> It seems that when running layout tests on linux, if there are no
>> special expected results for linux in chromium-linux, we fallback to
>> the special expected results for windows in chromium-win.  This is not
>> the case on mac if there are no results in chromium-mac, we take the
>> expectations that are next to the test even if there are other
>> expectations in chromium-win.  Is that on purpose?
>>
>> A related question: what is the intention with our custom expected
>> resulsts?  If we need to change the expectation for all three
>> platforms, should we only add the new expectations in chromium-win?
>> That sounds confusing to me.  Maybe we should have a chromium-common?
>>
>> Cheers,    -- Mads
>>
>> >>
>>
>

--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: [email protected] 
View archives, change email options, or unsubscribe: 
    http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to