On Tue, Feb 10, 2009 at 9:36 AM, Avi Drissman <[email protected]> wrote: > brettw, what's the meaning of the view returned from GetPluginNativeView()? > It seems to me that it's the actual view, in which case it feels like it's > mis-named and we should use it to return the actual view from the > RenderWidgetHostView rather than making new calls (native_view and > GetNativeView). If not, then what purpose does it serve in the greater > scheme?
It's passed into ViewMsg_New, which calls it a "parent window". Tracing the calls from there, it eventually goes into RenderWidget::CompleteInit, which stuffs it into host_window_. That's used in a few places (it appears to be used as a window id, see recent comments from agl on that) and eventually makes its way into webkit as a platformWindow. It seems ResourceMessageFilter doesn't have context other than the arguments supplied by the caller for answering calls like OnGetWindowRect? But we shouldn't be trusting HWND supplied by the renderer, so it seems bogus. --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
