PS: the change is here, if you want to patch it in (or just submit it!).

http://codereview.chromium.org/27036

On Sat, Feb 21, 2009 at 1:52 PM, Evan Martin <[email protected]> wrote:
> For a change I was doing on Linux to fix some memory corruption, I
> ended up pulling in hunspell into the browser link.
> This breaks on mac.  Can someone add hunspell to the mac browser
> dependency list for me?  (Or tell me how to do this with xcodebodge?)
> Then I will retry my change.
>
> I believe libbrowser.a should depend on it:
>
> http://build.chromium.org/buildbot/try-server/builders/mac/builds/3117/steps/compile/logs/stdio
>
> Ld /b/slave/mac/build/src/chrome/../xcodebuild/Debug/unit_tests normal i386
>   cd /b/slave/mac/build/src/chrome
>   setenv MACOSX_DEPLOYMENT_TARGET 10.5
>   /Developer/usr/bin/g++-4.2 -arch i386 -isysroot
> /Developer/SDKs/MacOSX10.5.sdk
> -L/b/slave/mac/build/src/chrome/../xcodebuild/Debug
> -L/b/slave/mac/build/src/chrome/../third_party/WebKit/WebKitLibraries
> -F/b/slave/mac/build/src/chrome/../xcodebuild/Debug -filelist
> /b/slave/mac/build/src/chrome/../xcodebuild/chrome.build/Debug/unit_tests.build/Objects-normal/i386/unit_tests.LinkFileList
> -mmacosx-version-min=10.5 -framework AppKit -framework
> ApplicationServices -framework Carbon -framework Foundation
> /b/slave/mac/build/src/xcodebuild/Debug/libbase.a
> /b/slave/mac/build/src/xcodebuild/Debug/libbase_gfx.a -lbrowser
> /b/slave/mac/build/src/xcodebuild/Debug/libbzip2.a -lcommon
> /b/slave/mac/build/src/xcodebuild/Debug/libevent.a
> /b/slave/mac/build/src/xcodebuild/Debug/libglue.a
> /b/slave/mac/build/src/xcodebuild/Debug/libgoogleurl.a
> /b/slave/mac/build/src/xcodebuild/Debug/libgtest.a
> /b/slave/mac/build/src/xcodebuild/Debug/libicudata.a
> /b/slave/mac/build/src/xcodebuild/Debug/libicui18n.a
> /b/slave/mac/build/src/xcodebuild/Debug/libicuuc.a
> /b/slave/mac/build/src/xcodebuild/Debug/libjpeg.a
> /b/slave/mac/build/src/xcodebuild/Debug/libjsbindings.a
> /b/slave/mac/build/src/xcodebuild/Debug/libjscre.a
> /b/slave/mac/build/src/xcodebuild/Debug/libmedia.a
> /b/slave/mac/build/src/xcodebuild/Debug/libmodp_b64.a
> /b/slave/mac/build/src/xcodebuild/Debug/libnet.a
> /b/slave/mac/build/src/xcodebuild/Debug/libpcre.a
> /b/slave/mac/build/src/xcodebuild/Debug/libpng.a
> /b/slave/mac/build/src/xcodebuild/Debug/libport.a -lrenderer
> /b/slave/mac/build/src/xcodebuild/Debug/libsdch.a
> /b/slave/mac/build/src/xcodebuild/Debug/libskia.a
> /b/slave/mac/build/src/xcodebuild/Debug/libsqlite.a
> /b/slave/mac/build/src/xcodebuild/Debug/libv8.a
> /b/slave/mac/build/src/xcodebuild/Debug/libwebcore.a
> /b/slave/mac/build/src/xcodebuild/Debug/libwebcoresysteminterface.a
> -lWebKitSystemInterfaceLeopard
> /b/slave/mac/build/src/xcodebuild/Debug/libwtf.a
> /b/slave/mac/build/src/xcodebuild/Debug/libxml.a
> /b/slave/mac/build/src/xcodebuild/Debug/libxslt.a
> /b/slave/mac/build/src/xcodebuild/Debug/libzlib.a -framework
> QuartzCore -framework Security -framework SystemConfiguration -o
> /b/slave/mac/build/src/chrome/../xcodebuild/Debug/unit_tests
> Undefined symbols:
>  "Hunspell::put_word(char const*)", referenced from:
>     SpellChecker::AddCustomWordsToHunspell()       in
> libbrowser.a(spellchecker.o)
>     SpellChecker::AddWord(std::basic_string<wchar_t,
> std::char_traits<wchar_t>, std::allocator<wchar_t> > const&)in
> libbrowser.a(spellchecker.o)
>  "Hunspell::suggest(char***, char const*)", referenced from:
>     SpellChecker::SpellCheckWord(wchar_t const*, int, int*, int*,
> std::vector<std::basic_string<wchar_t, std::char_traits<wchar_t>,
> std::allocator<wchar_t> >, std::allocator<std::basic_string<wchar_t,
> std::char_traits<wchar_t>, std::allocator<wchar_t> > > >*)in
> libbrowser.a(spellchecker.o)
>  "Hunspell::spell(char const*, int*, char**)", referenced from:
>     SpellChecker::IsValidContraction(std::basic_string<unsigned
> short, base::string16_char_traits, std::allocator<unsigned short> >
> const&)in libbrowser.a(spellchecker.o)
>     SpellChecker::SpellCheckWord(wchar_t const*, int, int*, int*,
> std::vector<std::basic_string<wchar_t, std::char_traits<wchar_t>,
> std::allocator<wchar_t> >, std::allocator<std::basic_string<wchar_t,
> std::char_traits<wchar_t>, std::allocator<wchar_t> > > >*)in
> libbrowser.a(spellchecker.o)
>  "Hunspell::Hunspell(unsigned char const*, unsigned long)", referenced from:
>     SpellChecker::Initialize()       in libbrowser.a(spellchecker.o)
>  "Hunspell::~Hunspell()", referenced from:
>     scoped_ptr<Hunspell>::reset(Hunspell*) in libbrowser.a(spellchecker.o)
>     scoped_ptr<Hunspell>::~scoped_ptr()in libbrowser.a(spellchecker.o)
> ld: symbol(s) not found
> collect2: ld returned 1 exit status
>

--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: [email protected] 
View archives, change email options, or unsubscribe: 
    http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to