great, thanks. On Sun, Feb 22, 2009 at 2:31 PM, Patrick Johnson <[email protected]>wrote:
> Hey John, > I filed a bug for the reliability crash ( > http://code.google.com/p/chromium/issues/detail?id=7951) and added it to > our known crashes file. > > Patrick > > > On Sat, Feb 21, 2009 at 12:12 PM, John Abd-El-Malek <[email protected]>wrote: > >> (CCing chrome-dev so that others who don't know can search for this later. >> Using Erik's & Huan's chromium emails so reply get sent to the list). >> >> I submitted some refactoring and now I'm seeing the reliability and purify >> tests are red, which I think is a false alarm due to callstacks changing. >> >> For the reliability tests, this is the new regression. I don't think my >> code could have affected this, so my hunch is that this callstack didn't >> match an existing list since RenderThread::OnMessageReceived is now >> ChildThread::OnMessageReceived. But I can't find out where the existing >> crash callstacks are stored so I can verify this? >> >> >> http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Reliability/builds/1155/steps/reliability%20tests/logs/stdio >> >> REGRESSION: NEW crash stack traces found >> -------------------- >> chrome_23e0000!WebCore::FrameLoader::submitFormAgain+0x1e >> [c:\b\slave\chromium-rel-xp\build\src\third_party\webkit\webcore\loader\frameloader.cpp >> @ 511] >> chrome_23e0000!WebCore::FrameLoader::executeScript+0x5d >> [c:\b\slave\chromium-rel-xp\build\src\third_party\webkit\webcore\loader\frameloader.cpp >> @ 788] >> chrome_23e0000!WebCore::HTMLTokenizer::scriptExecution+0xc7 >> [c:\b\slave\chromium-rel-xp\build\src\third_party\webkit\webcore\html\htmltokenizer.cpp >> @ 608] >> chrome_23e0000!WebCore::HTMLTokenizer::notifyFinished+0x204 >> [c:\b\slave\chromium-rel-xp\build\src\third_party\webkit\webcore\html\htmltokenizer.cpp >> @ 1986] >> chrome_23e0000!WebCore::CachedScript::addClient+0x23 >> [c:\b\slave\chromium-rel-xp\build\src\third_party\webkit\webcore\loader\cachedscript.cpp >> @ 57] >> chrome_23e0000!WebCore::HTMLTokenizer::scriptHandler+0x404 >> [c:\b\slave\chromium-rel-xp\build\src\third_party\webkit\webcore\html\htmltokenizer.cpp >> @ 494] >> chrome_23e0000!WebCore::HTMLTokenizer::parseSpecial+0x3fd >> [c:\b\slave\chromium-rel-xp\build\src\third_party\webkit\webcore\html\htmltokenizer.cpp >> @ 347] >> chrome_23e0000!WebCore::HTMLTokenizer::parseTag+0x112c >> [c:\b\slave\chromium-rel-xp\build\src\third_party\webkit\webcore\html\htmltokenizer.cpp >> @ 1495] >> chrome_23e0000!WebCore::HTMLTokenizer::write+0x410 >> [c:\b\slave\chromium-rel-xp\build\src\third_party\webkit\webcore\html\htmltokenizer.cpp >> @ 1726] >> chrome_23e0000!WebCore::HTMLTokenizer::notifyFinished+0x27c >> [c:\b\slave\chromium-rel-xp\build\src\third_party\webkit\webcore\html\htmltokenizer.cpp >> @ 2014] >> chrome_23e0000!WebCore::CachedImage::checkNotify+0x3a >> [c:\b\slave\chromium-rel-xp\build\src\third_party\webkit\webcore\loader\cachedimage.cpp >> @ 320] >> chrome_23e0000!WebCore::CachedScript::data+0x99 >> [c:\b\slave\chromium-rel-xp\build\src\third_party\webkit\webcore\loader\cachedscript.cpp >> @ 98] >> chrome_23e0000!WebCore::Loader::Host::didFinishLoading+0xab >> [c:\b\slave\chromium-rel-xp\build\src\third_party\webkit\webcore\loader\loader.cpp >> @ 305] >> chrome_23e0000!WebCore::SubresourceLoader::didFinishLoading+0x2b >> [c:\b\slave\chromium-rel-xp\build\src\third_party\webkit\webcore\loader\subresourceloader.cpp >> @ 183] >> chrome_23e0000!WebCore::ResourceLoader::didFinishLoading+0x7 >> [c:\b\slave\chromium-rel-xp\build\src\third_party\webkit\webcore\loader\resourceloader.cpp >> @ 417] >> chrome_23e0000!WebCore::ResourceHandleInternal::OnCompletedRequest+0xf7 >> [c:\b\slave\chromium-rel-xp\build\src\webkit\glue\resource_handle_impl.cc @ >> 636] >> chrome_23e0000!ResourceDispatcher::OnRequestComplete+0x86 >> [c:\b\slave\chromium-rel-xp\build\src\chrome\common\resource_dispatcher.cc @ >> 419] >> chrome_23e0000!IPC::MessageWithTuple<Tuple2<int,URLRequestStatus> >> >::Dispatch<ResourceDispatcher,void (__thiscall >> ResourceDispatcher::*)(int,URLRequestStatus const &)>+0x30 >> [c:\b\slave\chromium-rel-xp\build\src\chrome\common\ipc_message_utils.h @ >> 1135] >> chrome_23e0000!ResourceDispatcher::DispatchMessageW+0x97 >> [c:\b\slave\chromium-rel-xp\build\src\chrome\common\resource_dispatcher.cc @ >> 464] >> chrome_23e0000!ResourceDispatcher::OnMessageReceived+0x174 >> [c:\b\slave\chromium-rel-xp\build\src\chrome\common\resource_dispatcher.cc @ >> 277] >> chrome_23e0000!RenderView::OnMessageReceived+0x81 >> [c:\b\slave\chromium-rel-xp\build\src\chrome\renderer\render_view.cc @ 333] >> chrome_23e0000!MessageRouter::RouteMessage+0x34 >> [c:\b\slave\chromium-rel-xp\build\src\chrome\common\message_router.cc @ 39] >> chrome_23e0000!MessageRouter::OnMessageReceived+0x30 >> [c:\b\slave\chromium-rel-xp\build\src\chrome\common\message_router.cc @ 30] >> chrome_23e0000!ChildThread::OnMessageReceived+0x36 >> [c:\b\slave\chromium-rel-xp\build\src\chrome\common\child_thread.cc @ 72] >> chrome_23e0000!RunnableMethod<history::HistoryBackend,void (__thiscall >> history::HistoryBackend::*)(GURL const &),Tuple1<GURL> >::Run+0x17 >> [c:\b\slave\chromium-rel-xp\build\src\base\task.h @ 308] >> chrome_23e0000!MessageLoop::RunTask+0x80 >> [c:\b\slave\chromium-rel-xp\build\src\base\message_loop.cc @ 309] >> chrome_23e0000!MessageLoop::DoWork+0x1ea >> [c:\b\slave\chromium-rel-xp\build\src\base\message_loop.cc @ 416] >> chrome_23e0000!base::MessagePumpDefault::Run+0x111 >> [c:\b\slave\chromium-rel-xp\build\src\base\message_pump_default.cc @ 50] >> chrome_23e0000!MessageLoop::RunInternal+0xb7 >> [c:\b\slave\chromium-rel-xp\build\src\base\message_loop.cc @ 197] >> chrome_23e0000!MessageLoop::RunHandler+0xa0 >> [c:\b\slave\chromium-rel-xp\build\src\base\message_loop.cc @ 181] >> chrome_23e0000!MessageLoop::Run+0x3d >> [c:\b\slave\chromium-rel-xp\build\src\base\message_loop.cc @ 155] >> chrome_23e0000!base::Thread::ThreadMain+0x8a >> [c:\b\slave\chromium-rel-xp\build\src\base\thread.cc @ 159] >> chrome_23e0000!`anonymous namespace'::ThreadFunc+0xd >> [c:\b\slave\chromium-rel-xp\build\src\base\platform_thread_win.cc @ 27] >> WARNING: Stack unwind information not available. Following frames may be >> wrong. >> kernel32!GetModuleFileNameA+0x1b4 >> >> >> >> For the purify tests, I think the situation is a little better. There are a >> bunch of unexpected fixes, due to me running a message loop a little longer >> in a test to make sure SyncChannel destructs correctly. >> >> http://build.chromium.org/buildbot/waterfall/builders/XP%20Unit%20(purify)/builds/2253/steps/purify%20test:%20unit/logs/stdio >> >> The first entry is "2 new 'Uninitialized Memory Read(UMR)' unexpected fixes >> found". These are because of the longer lived message loop. >> >> The second entry is "1 'Memory Leak(MLK)' messages (1 new, 8 unexpectedly >> fixed)". I believe the 7 of the unexpected fixes are due to the same reason >> as above. The one new has ChildThread in the callstack, which had been >> RenderThread before (it's the first unexpected fix right after). >> >> Thanks, >> John >> >> >> >> >> > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
