I realize our checkouts are big, but there is a ton of other stuff besides NSS. I don't really see the point in trying to do this just now, it's seems likely to break a bunch of other platforms and be a bit of a mess. If you feel that it's that important, ok, don't break anything :)
On Thu, Feb 26, 2009 at 8:36 AM, Darin Fisher <[email protected]> wrote: > Hmm... I'm OK with having the small duplication of NSS/NSPR code for the > foreseeable future. I think it is nice that base doesn't require all of > NSS+NSPR. So, I guess that's a +1 in favor of moving it to deps_os as > planned. > > -Darin > > > > On Wed, Feb 25, 2009 at 9:08 PM, Michael Moss <[email protected]> wrote: >> >> Does that imply that it shouldn't move to deps? We can restrict it to >> Linux with deps_os now, and then make it apply to all platforms later, >> right? Or is it better to just leave it in trunk since it's already >> there? I'm fine with it either way, though it's less hassle for me to >> leave it where it is, and it means it's in my git tree instead of >> gclient/svn, but that's only a minor benefit since I don't expect to >> be changing it a lot once all these initial commits are in. >> >> Michael >> >> On Wed, Feb 25, 2009 at 8:08 PM, Darin Fisher <[email protected]> wrote: >> > If we do that cleanup, then we will need NSS and NSPR on all platforms. >> > -Darin >> > >> > >> > On Wed, Feb 25, 2009 at 7:31 PM, Michael Moss <[email protected]> >> > wrote: >> >> >> >> There are actually both nss and nspr under base, but only a handful of >> >> files, not the whole trees. I plan to clean those up as appropriate, >> >> once this is all in and working. >> >> >> >> Michael >> >> >> >> On Wed, Feb 25, 2009 at 5:15 PM, Lei Zhang <[email protected]> >> >> wrote: >> >> > >> >> > BTW, we have both src/third_party/nss/ and src/base/third_party/nss/. >> >> > >> >> > On Wed, Feb 25, 2009 at 5:04 PM, Thomas Van Lenten >> >> > <[email protected]> wrote: >> >> >> Sorry for arriving late w/ this question... >> >> >> >> >> >> I'm guessing NSS & NSPR are needed for the linux build? Should they >> >> >> be >> >> >> pulled in via DEPS instead of being directly in src/third_party? In >> >> >> the >> >> >> current form it causes both mac and windows to have to add ~80M to >> >> >> their svn >> >> >> trees that really isn't needed. >> >> >> >> >> >> TVL >> >> >> >> >> >> >> >> >> > >> >> >> >> >> > >> >> > > >> >> > >> >> >> >> >> >> > >> > > > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
