Because you're reusing display methods that retrieve metrics, I assume your tabstrip will have exactly the same bounds for itself and its contents as the windows one?
-Ben On Tue, Mar 3, 2009 at 11:49 AM, James Hawkins <[email protected]> wrote: > On Tue, Mar 3, 2009 at 11:36 AM, Ben Goodger (Google) <[email protected]> > wrote: >> Can you give a more detailed breakdown of the code/methods that'll be >> moved to the shared base? >> > > To be shared: > * All of the TabAnimation classes. > * The following methods: > - GetPreferredHeight > - CanProcessInputEvents > - PointIsWithinWindowCaption, though we don't have a custom frame on linux > yet > - IsCompatibleWith > - IsAnimating > - model > - IsDragSessionActive > - AbortActiveDragSession > - DestroyDragController > - DestroyDraggedSourceTab > - GetIdealBounds > - UpdateLoadingAnimations > - TabStripModelObserver implemenation > - Tab::Delegate implemenation > - GetTabAt > - GetTabAtAdjustForAnimation > - GetTabCount > - GetCurrentTabWidths > - GetDesiredTabWidths > - ResizeLayoutTabs > - all of the methods under the Animations section > > It's probably easier to look at it from the other side though, i.e. > how much are we taking out of TabStrip? > * The following inherited super-classes: > - views::View > - views::Button::ButtonListener > - MessageLoopForUI::Observer > * Any platform-specific code, usually Views overrides. > > -- > James Hawkins > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
