Just following up, I'll start whacking on TabContents as soon as I can get a patch landed that overlaps with temp_scaffolding_stubs. Of course, that means the tree will have to open for more than 15 minutes :-).
The faster we can get TabContents out of that file, the better. On Wed, Mar 4, 2009 at 9:41 AM, Mike Pinkerton <[email protected]> wrote: > Well, its not *verbatim*, but it is starting to converge on the real > thing. Here's the history: > > When we started porting the front-ends, we just stubbed the big > classes enough to get it limping, filling in empty declarations to > avoid de-HWNDifying everything and dragging in tons of headers that > weren't yet really needed. This worked quite well. TabContents was a > major piece, but it had a lot of Win32 dependencies with the native UI > pages (download manager, history, etc). We were able to get quite far > with just a stub of TabContents and not the real McCoy. We considered > fleshing out the real one, but it was always on the verge of going > away as Glen moved the native UIs to HTML. Once everything was HTML, > we'd only need WebContents and TabContents could fade into > obsolescence, thus no need to spend much time on it. > > As we started hooking up more and more functionality, however, > TabContents grew bigger and bigger. And bigger. And became more and > more like its counterpart, just lacking in all the right places to > drive you mad. This is something that's been in the back of my mind to > clean up, I've just been distracted with other stuff. I will talk to > Glen and Brett about if we're in the right place to get rid of it, or > just port it once and for all. > > Hope that helps. > > On Wed, Mar 4, 2009 at 7:33 AM, Dean McNamee <[email protected]> wrote: >> >> I am working on Linux omnibox, and chasing a stupid crash into >> temp_scaffolding_stubs.cc (TabContents). >> >> Every method I looked at was just a copy and paste from >> tab_contents.cc, without any modifications. Why? Why are we not just >> using the code in tab_contents.cc ? There is just a massive ifdef >> around it, with no comment as to what doesn't work, why it copied >> verbatim into stubs, etc. Totally confused. >> >> Thanks >> -- dean >> >> >> >> > > > > -- > Mike Pinkerton > Mac Weenie > [email protected] > -- Mike Pinkerton Mac Weenie [email protected] --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
