Also, for help when you're retrying your patch. Purify was warning about memory errors, which is why Nicolas originally reverted:
http://build.chromium.org/buildbot/waterfall/builders/XP%20Unit%20(purify)/builds/2466/steps/purify%20test:%20unit/logs/stdio On Thu, Mar 5, 2009 at 7:05 PM, Dean McNamee <[email protected]> wrote: > On Thu, Mar 5, 2009 at 7:03 PM, Alpha (Hin-Chung) Lam <[email protected]> > wrote: >> >> 2009/3/5 Amanda Walker <[email protected]> >>> >>> On Thu, Mar 5, 2009 at 12:38 PM, Alpha (Hin-Chung) Lam <[email protected]> >>> wrote: >>> > everytime I do a checkin I do a sync and send it >>> > to the try server, which really takes me a lot of time, but still try >>> > server >>> > is showing me green light to check in, am I suppose to not trust the try >>> > server and rely on human intelligence? >>> >>> In this case watching the build wouldn't have helped, since the >>> buildbots stayed green (I had misinterpreted Dean's original message, >>> the tone of which he has since apologized for). >>> >>> However, to answer the general question, you should not completely >>> trust the try server. If the try server breaks, it's a very good >>> indication that an actual commit would break, but the reverse is not >>> true. If the try server succeeds, it doesn't mean that a commit will >>> succeed, since the try server runs fewer tests (and there may be >>> commits to the tree in between doing a try and doing a commit). So >>> even if the try succeeds, it's still important to watch the buildbots >>> to make sure the actual commit also succeeds. That wasn't the problem >>> in this instance (you wouldn't have seen this failure), but I wanted >>> to make sure people don't rely too much on the try server. It's a >>> good "preflight check", but it won't catch everything. >> >> Thanks Amanda and Nicolas for the clarifactions. >> Sorry Dean for wasting your time to debug, I should have comminucated better >> as the patch really is posix specific. >> Sorry all chromium commiters if I have caused trouble to you. > > Hey, it's no big deal. I just want to make sure we took the instance > as an example of how we can improve our build setup, and how we can > keep the tree more stable. > >> >> Alpha >> >>> >>> --Amanda >> >> >> >> >> > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
