[+chromium-dev] No, I'll do this in PRESUBMIT.py (probably tomorrow or in the next few days), in fact in the canned one.
All gcl checks needs to be moved in the PRESUBMIT thing for: 1. consistency 2. simplify the gcl code which is already large enough. M-A On Thu, Mar 19, 2009 at 10:36 AM, Nicolas Sylvain <[email protected]> wrote: > fun fact: we added code in the svn server to block all changelists with > comments, but there there is a comment, it's the code review url! I don't > really want to add more complicated parsing in svn, so gcl seems like a > better place to do this. > Nicolas > > On Thu, Mar 19, 2009 at 4:45 AM, Marc-Antoine Ruel <[email protected]> > wrote: >> >> Whoever wants to, it's a tad early for me atm. >> >> On Mar 19, 2009 7:44 AM, "Dean McNamee" <[email protected]> wrote: >> >> On Thu, Mar 19, 2009 at 12:41 PM, Marc-Antoine Ruel <[email protected]> >> wrote: > We just need a pres... >> >> Ok, will we do that? >> >> > > On Mar 19, 2009 7:27 AM, "Dean McNamee" <[email protected]> wrote: > >> > > > This commit had no log.... >> >> > >> > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
