Do you recommend me to refactor the Context Menu code from BitmapScrollBar into ScrollBar so that both will have context menu implementations?
Currently, the context menu is the page context menu that has "reload, print, view page info, etc". Would that be the best approach fixing this "feature" bug. http://code.google.com/p/chromium/issues/detail?id=7231 -m0 On Wed, Mar 25, 2009 at 3:49 PM, Ben Goodger (Google) <[email protected]> wrote: > There are different kinds of scrollbar supported by views... that > native scrollbar and the bitmap scrollbar. bitmap scrollbar isn't used > right now but likely will be again. > > ScrollBar is the base class of both NativeScrollbar and > Bitmapscrollbar. Scrollview has a ScrollBar* so it doesn't have to > care about the particular implementation. > > -Ben > > On Tue, Mar 24, 2009 at 6:36 PM, Mohamed Mansour > <[email protected]> wrote: >> Hi chromium, >> >> I cc'd Ben cause he seems to be working on UI on chrome alot :x Sorry >> Ben! I am working on a "feature" >> http://code.google.com/p/chromium/issues/detail?id=7231 which requires >> context menu support for Chromium scroll bars. While searching the >> code I have come up with these classes: >> >> - NativeScrollBar >> - ScrollBar >> - ScrollView >> - BitmapScrollBar >> >> The context menu functionality should have the following (system wide >> in windows, every window that has scrollbar, has that context menu) >> >> Horizontal: >> 1) Scroll Here >> 2) Left Edge >> 3) Right Edge >> 4) Page Left >> 5) Page Right >> 6) Scroll Left >> 7) Scroll Right >> >> Vertical: >> 1) Scroll Here >> 2) Top >> 3) Bottom >> 4) Page Up >> 5) Page Down >> 6) Scroll Up >> 7) Scroll Down >> >> >> So my question is as follows, Chromium uses ScrollView as its main >> scroll bar. It doesn't use NativeScrollBar, nor BitmapScrollBar. So >> why do those exist? Why do we have a ScrollBar class? Why can't we >> just use ScrollView and instead of passing in a ScrollBar, are we >> assuming Chromium will have *many* different types of scrollbars? >> >> Why are we not using native windows scrollbar support, since chromium >> is creating different views in every operating system, why not just >> use the standard windows components? >> >> There are many functionality within the scrollbar, how would you guys >> advice me to continue? Should I create a separate class called >> ScrollBarContextMenu and implement the horizontal and vertical context >> menu for scroll bars? >> >> There must be an easier way, to just use windows/gtk/mac controls for >> scrollbar support, instead of recreating it from scratch. >> >> Ideas? >> > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
