Chromium-developers,

Sorry for my stupid question.
I'm writing a fix for Issue 2215 and its UI test to verify a DOM event
sent when we press a VK_MENU key, which is uploaded into Rietveld
(*1). Even though this UI test works fine on my PCs, it always fails
on a try bot.

(*1) http://codereview.chromium.org/42500/show

To analyze the failure log listed below, it seems a DOM event is not
sent to my onkeydown handler even when I send a keyboard event with a
WindowProxy::SimulateOSKeyPress() call.
Would it be possible to give me any hints why my UI test fails on a try bot?

[----------] 1 test from InputTest
[ RUN      ] InputTest.ModifierKeys
..\..\browser\input_uitest.cc(46): error: Value of: GetActiveTabTitle()
  Actual: L"KeyCode Test"
Expected: L"SUCCEEDED"
..\..\browser\input_uitest.cc(46): error: Value of: GetActiveTabTitle()
  Actual: L"KeyCode Test"
Expected: L"SUCCEEDED"
..\..\browser\input_uitest.cc(46): error: Value of: GetActiveTabTitle()
  Actual: L"KeyCode Test"
Expected: L"SUCCEEDED"
[  FAILED  ] InputTest.ModifierKeys (61250 ms)
[----------] 1 test from InputTest (61250 ms total)

Regards,

Hironori Bono
E-mail: [email protected]

---------- Forwarded message ----------
From:  <[email protected]>
Date: Wed, Mar 25, 2009 at 10:31 PM
Subject: Re: A quick fix for Issue 2215....
To: [email protected]
Cc: [email protected]


With changes, lgtm.

I don't know UI tests well, and don't know why this might fail. You
might want to ask the list for their thoughts.


http://codereview.chromium.org/42500/diff/28/2017
File chrome/browser/input_unittest.cc (right):

http://codereview.chromium.org/42500/diff/28/2017#newcode1
Line 1: // Copyright (c) 2006-2008 The Chromium Authors. All rights
reserved.
Fix the copyright date; 2009.

http://codereview.chromium.org/42500/diff/28/2017#newcode1
Line 1: // Copyright (c) 2006-2008 The Chromium Authors. All rights
reserved.
This file has a bad name. UI tests are named xxx_uitest.cc; see the
vcproj to see examples.

http://codereview.chromium.org/42500

--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: [email protected] 
View archives, change email options, or unsubscribe: 
    http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to