I can see how that's happening in pref_service_uitest.cc and memory_test.cc, but AFAICT I don't see how it's being done generally for ui_tests test cases. Perhaps it's that --user-data-dir should be passed to ui_tests itself, which means if you run ui_tests without that flag, it will still use your default profile. Or maybe I misunderstand entirely.
BTW, I was just stupid when I thought that Mac was broken because of being hacked together. Some of the profile setup is certainly hacked together, but as far as I can tell, it does the right thing for --user-data-dir (though having it fall back to the default dir when the provided one doesn't exist threw me for awhile, that seems unexpected). -scott On Wed, Apr 8, 2009 at 11:23 AM, Darin Fisher <[email protected]> wrote: > Also, unless you do something like this, it ends up being difficult for > developers to dogfood the product, or if they do try to dogfood the product, > then they are strongly inscentivized not to run the ui_tests. Neither > option is good. > -Darin > > On Wed, Apr 8, 2009 at 11:21 AM, Darin Fisher <[email protected]> wrote: >> >> Maybe this is well known, but what we did to avoid this problem on Windows >> is to leverage the --user-data-dir command line switch to force the chrome >> instance launched by the ui_tests to use a dedicated user data directory. >> We toss that directory prior to each test case IIRC. >> -Darin >> >> On Wed, Apr 8, 2009 at 11:10 AM, Scott Hess <[email protected]> wrote: >>> >>> I posted this on the irc channel yesterday, I know at least Peter >>> noticed, but John suggested something more overt. >>> >>> When you run ui_tests on Mac, you will blow away some fraction of your >>> Chromium.app profile. Things like history and bookmarks. This is a >>> known issue, but may not be a known consequence. If anyone wants to >>> circle back and fix profiles, that would be wonderous. I was thinking >>> of looking at it myself, but am instead trying to figure out where my >>> omnibox stuff is going wrong. >>> >>> It occurs to me that if you ran ui_tests while running Chromium.app, >>> or two ui_tests, you may also see strange and wonderful results. >>> >>> -scott >>> >>> >>> >> > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
