maybe we should get this checked in to keep VS2008 devs out there happy. On Wed, Apr 22, 2009 at 4:42 PM, Sverrir Á. Berg <[email protected]>wrote:
> See: http://codereview.chromium.org/92037 > Sverrir > > > > On Wed, Apr 22, 2009 at 4:29 PM, Tommi <[email protected]> wrote: > >> I'm still getting those errors. Like Sverrir I'm using VS2008. What's >> the magic required to get chrome.dll to link? >> >> >> On Wed, Apr 22, 2009 at 11:02 AM, Mike Belshe <[email protected]> wrote: >> >>> It should work :-) >>> I'd check chrome/app/chrome_dll.vcproj for changes. >>> >>> The basic idea is: >>> * these functions are now provided by an alternate libcmt which is in >>> the tcmalloc directory. >>> * there is a build step as part of tcmalloc which creates this library >>> (prep_libc.sh) >>> * chrome.dll now ignores libcmt.lib and manually links its own libcmt. >>> >>> Mike >>> >>> >>> >>> On Wed, Apr 22, 2009 at 7:25 AM, Sverrir Á. Berg >>> <[email protected]>wrote: >>> >>>> Even after doing the clobber & runhooks raindance I'm getting linker >>>> errors: >>>> 143>tcmalloc.lib(override_functions.obj) : error LNK2005: _malloc >>>> already defined in libcmt.lib(malloc.obj) >>>> 143>tcmalloc.lib(override_functions.obj) : error LNK2005: _free already >>>> defined in libcmt.lib(free.obj) >>>> 143>tcmalloc.lib(override_functions.obj) : error LNK2005: _calloc >>>> already defined in libcmt.lib(calloc.obj) >>>> ... (16 functions total) >>>> >>>> (VS2008/external depot) >>>> >>>> Any suggestions on how to solve this? >>>> Sverrir >>>> >>>> >>>> On Wed, Apr 22, 2009 at 10:05 AM, Mike Belshe <[email protected]>wrote: >>>> >>>>> I turned on tcmalloc last night as an experiment. I left it on so far. >>>>> The good news is the perf: >>>>> http://build.chromium.org/buildbot/perf/dashboard/overview.html >>>>> >>>>> The bad news is the reliability bot shows some crashes. I believe >>>>> these are crashes not caused by tcmalloc but exposed by it. We'll figure >>>>> out a plan to fix them today, or to revert tcmalloc again. >>>>> >>>>> Thanks for your patience while we sort this out! >>>>> >>>>> Mike >>>>> >>>>> >>>>> >>>>> >>>> >>> >>> >>> >>> >> > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
