I want to extract views/ from chrome/ so it can be used by other projects.
Before this can be done, views' dependencies on other dirs need to be tidied up. Right now it depends on: base/ build/build_config.h chrome/app/chrome_dll_resource.h chrome/common/clipboard_service.h chrome/common/drag_drop_types.h chrome/common/gfx/chrome_canvas.h chrome/common/gfx/chrome_font.h chrome/common/gfx/favicon_size.h chrome/common/gfx/icon_util.h chrome/common/gfx/insets.h chrome/common/gfx/path.h chrome/common/l10n_util.h chrome/common/l10n_util_win.h chrome/common/logging_chrome.h chrome/common/message_box_flags.h chrome/common/notification_registrar.h chrome/common/notification_service.h chrome/common/notification_observer.h chrome/common/os_exchange_data.h chrome/common/pref_service.h chrome/common/resource_bundle.h chrome/common/win_util.h chrome/common/scoped_vector.h chrome/common/stl_util-inl.h chrome/common/throb_animation.h chrome/tools/build/win/precompiled.h googleurl/src/gurl.h grit/generated_resources.h grit/theme_resources.h skia/ third_party/WebKit/WebKit/chromium/public/WebInputEvent.h webkit/glue/window_open_disposition.h the base/, build/, skia/ and googleurl/ deps are probably fine. The common deps need to be sorted out. After some discussion with Darin and Brett we think creating a new top level directory called "app" that contains these files from common is a good idea. Basically the purpose of this new directory is to hold shared resources used to build a UI application independent of what toolkit is used to do the UI. This would be included by the views and gtk front ends. so at the end of the day we'd end up with two new toplevel dirs: src/app src/views (A small subset of the common dependencies above could just be moved to base, like stl_util-inl.h) Some of the other dependencies above are just bogus and should be fixed. If no one objects too strenuously, I'll begin doing this this week. -Ben --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
