The more I think about this, the more trouble we might be in :-) Page cyclers are also misleading as they test Test Shell, not Chrome. To illustrate I ran a few tests with the moz page cycler:
Test-shell: 29.41 Chrome default: 37.43 Chrome w/ Extensions and Web Workers 39.41 // these are not enabled yet. Chrome w/o chrome-specific v8 extensions: 36.35 Conclusions: * Chrome is 27% slower than test shell. We knew this. * When we turn on extensions and web workers, Chrome will regress by 5.3%. This would not be detected by our automated tests. * We already have a 3% hit due to using v8 extensions (Interval, CSI, etc) which we hadn't detected via automation. Mike On Wed, Apr 29, 2009 at 2:18 PM, Mark Larson (Google) <[email protected]>wrote: > > > On Wed, Apr 29, 2009 at 14:05, Mike Belshe <[email protected]> wrote: > >> We're still using the test-shell to run the LayoutTests. I just fixed a >> bug, wrote a layout test, and then realized how dumb I was because the code >> I was testing was only in Chrome, and not in the test_shell. >> >> I think we're accumulating a lot of code that is chrome specific, but >> which could effect rendering and layout. In my case, I'm working on v8 >> extensions that have been put into the browser, but there is tons of code >> which differs between chrome and test shell. Not having layout tests for >> chrome itself is making me a bit nervous. >> >> 2 Questions: >> >> 1) Any plans already underway to run chrome rather than test_shell through >> the Layout Tests? >> > > No. > > >> >> 2) Should we create those plans :-) >> > > Based on the response to this thread, sounds like "yes." I filed a bug. > > I don't know what's involved to support running layout tests effectively in > the browser itself. > > If you have an idea of what needs to be done, please update > http://bugs.chromium.org/11186. > >> >> Cheers, >> Mike >> >> >> >> >> >> > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
