I created http://codereview.chromium.org/99309 for you. Thanks.
On Fri, May 1, 2009 at 4:25 PM, LivioSoares <[email protected]> wrote: > > Dear Chromium folks, > > I was building revision 15114 this afternoon and was snagged by > this: > > cc1plus: warnings being treated as errors > In file included from /home/livio/src/chrome/chromium/src/chrome/ > browser/extensions/extension.h:19, > from /home/livio/src/chrome/chromium/src/chrome/ > common/resource_bundle.h:21, > from /home/livio/src/chrome/chromium/src/chrome/ > common/jstemplate_builder.cc:13: > /home/livio/src/chrome/chromium/src/chrome/common/page_action.h:22: > error: 'typedef' was ignored in this declaration > scons: *** [/home/livio/src/chrome/chromium/src/sconsbuild/Release/obj/ > chrome/common/jstemplate_builder.o] Error 1 > > I'm compiling under Linux (Debian/unstable), GCC version 4.3.3. > > It seems that the following small changes fixes it. > > Cheers, > > Livio > >> svn diff src/chrome/common/page_action.h > Index: src/chrome/common/page_action.h > =================================================================== > --- src/chrome/common/page_action.h (revision 15114) > +++ src/chrome/common/page_action.h (working copy) > @@ -16,10 +16,10 @@ > PageAction(); > virtual ~PageAction(); > > - typedef enum PageActionType { > + typedef enum { > PERMANENT = 0, > TAB = 1, > - }; > + } PageActionType; > > std::string id() const { return id_; } > void set_id(std::string id) { id_ = id; } > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
