2009/5/4 Darin Fisher <da...@chromium.org>: > Maybe we can reuse MakeTuple and DispatchToFunction from base/tuple.h ? > -Darin
I started looking at this, but it ends up being a fair amount of template magic to deal with a situation which hasn't ever actually happened in the code (even without the macro, where it would have been safe). I suspect that it's not worth the added complexity. So I shrugged and landed the patch - given the number of files I was starting to see conflicts when merging trunk already. If this ever actually bites us: then I was wrong. But there's a big warning in the header and code reviewers are aware of the issue now. Hopefully that will stop it being a problem. AGL --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---