2009/5/6 Andrew Scherkus <scher...@chromium.org>: > We'll ping WebKit to find out the reasoning behind passing in a > GraphicsContext. Probably for performance reasons and reducing extra > blits/copies, but still worth investigating.
Probably that and preserving any active transforms, as Brett noted. > For some background > information... each platform implementation of MediaPlayerPrivate either > stores video frames on a platform-dependent surface (cairo_surface_t, > SkBitmap) or uses a platform-dependent context (HDC, NSGraphicsContext) to > interact with an external library (QTKit on mac, QuickTime on Windows). Sure--the difficulty only comes up because some things that are normally per-platform in WebKit, we push down a layer, which works well in general but leads to some rough edges when PLATFORM(CHROMIUM) meets PLATFORM(CG). This is where the "#ifdefs everywhere" that you were hoping to avoid come into play. How many #ifdefs would it really be? --Amanda --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---