On Tue, May 12, 2009 at 3:16 AM, Darin Fisher <[email protected]> wrote:
> Then, create a .gclient file like so:
>
> solutions = [
> { "name" : "src",
> "url" : "http://src.chromium.org/svn/trunk/src";,
> "custom_deps" : {
> 'src/third_party/WebKit': '
> http://svn.webkit.org/repository/webkit/trunk',
> 'src/third_party/WebKit/JavaScriptCore': None,
> 'src/third_party/WebKit/WebCore': None,
> 'src/third_party/WebKit/WebKitLibraries': None,
> 'src/third_party/WebKit/WebKit/mac': None,
> 'src/webkit/data/layout_tests/LayoutTests': None,
>
Doesn't this keep you from being able to run the layout tests in TestShell?
Maybe it's time someone took the effort to fix
http://bugs.chromium.org/8765to make this world a bit more consistent?
Once bug 8765 gets fixed, I wonder if there's something simpler we could
do.
It seems to me that the ideal solution would be that a default Chromium
checkout could be used for both Chromium development and WebKit development.
This is a lot more friendly to people who are new to the team and for people
that need to work in both trees. As long as there is a way for people who
are only working on Chromium to exclude the LayoutTests directory (which is
~90% of the WebKit checkout).
I'm not sure I've fully thought this through, but could we change the
default to be that src/third_party/WebKit points at
http://svn.webkit.org/repository/webkit/trunk'? Then people who don't want
LayoutTests, et al, can do something like the following:
solutions = [
{ "name" : "src",
"url" : "http://src.chromium.org/svn/trunk/src";,
"custom_deps" : {
'src/third_party/WebKit': '/trunk/deps/third_party/WebKit',
'src/third_party/WebKit/JavaScriptCore': Var("webkit_trunk") + "/
JavaScriptCore@" + Var("webkit_revision"),
'src/third_party/WebKit/WebCore': Var("webkit_trunk") + "/WebCore@" +
Var("webkit_revision"),
'src/third_party/WebKit/WebKitLibraries': Var("webkit_trunk") + "/
WebKitLibraries@" + Var("webkit_revision"),
'src/third_party/WebKit/WebKit': Var("webkit_trunk") + "/WebKit@" +
Var("webkit_revision"),
}
}
]
Note that the Var stuff will mean that you'll pull from whatever SVN server
/ webkit revision that's specified in src/DEPS. I'm not actually sure that
will work from the gclient file, but we should make it work if it doesn't.
:)
Ojan
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: [email protected]
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
