What is the point of a single trailing underscore? Wouldn't it make more sense to match webkit and have no trailing underscore?
-Benjamin Meyer On Tue, May 12, 2009 at 8:32 AM, Dean McNamee <[email protected]> wrote: > > Yes, this is legacy. You'll see that new code uses (at least should > use) a single trailing underscore: > > cpu.h:#ifndef BASE_CPU_H_ > cpu.h:#define BASE_CPU_H_ > cpu.h:#endif // BASE_CPU_H_ > > It should be an easy mass replace, but it's not really more than an > ideological concern. We've just been slowly updating guards as we > touch the files. > > Thanks > -- dean > > On Tue, May 12, 2009 at 1:37 PM, Glider <[email protected]> wrote: >> >> Hi chromium-dev, >> >> The Chromium header files begin with a sentry section that looks like: >> #ifndef PATH_FILENAME__ >> #define PATH_FILENAME__ >> >> However, the names containing __ are reserved according to the C++ >> standard and cannot be used. >> >> Is that a legacy in the codebase, or should it be fixed? >> >> WBR, >> Alexander Potapenko >> >> >> > >> > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
