It would save effort if you discussed the changes you plan to make before writing code. Otherwise just drop us an email and point to the CL (screenshots help, as not all of the team are engineers).
On Wed, May 27, 2009 at 2:19 PM, Mohamed Mansour<[email protected]> wrote: > So do we send a CL to all of you guys or just one? Assuming all of you > touched it. > -- Mohamed Mansour > > On Wed, May 27, 2009 at 4:01 PM, Ben Goodger (Google) <[email protected]> > wrote: >> >> Also FYI, >> >> If you're just porting existing UI to a different platform, no need to >> discuss with us. Same thing if it's a platform specific difference >> that we've discussed previously (e.g. we know there's a menu bar on >> the Mac). >> >> The intent with this is to catch new features that don't exist on any >> platform yet as they creep in. >> >> -Ben >> >> On Wed, May 27, 2009 at 12:36 PM, Ben Goodger (Google) <[email protected]> >> wrote: >> > This has happened a couple of times now. If you're adding any visible >> > user interface, even if it's just a checkbox to the advanced page of >> > Options, you must discuss it with: >> > >> > myself (ben@) >> > Glen Murphy (glen@) >> > Nick Baum (nickbaum@) >> > Brian Rakowski (brian@) >> > >> > first. If you don't, it's highly likely that your change will be >> > reverted :-) >> > >> > -Ben >> > >> >> > > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
