Ok this patch is in now.Good catch Albert! -BradN
On Sat, May 30, 2009 at 8:41 AM, Albert J. Wong (王重傑) <ajw...@chromium.org>wrote: > Found this yesterday. > > If any of the hex digits in the msvs_guid (specified in the .gyp files) for > your target are lowercase, IncrediBuild's BuildConsole will silently ignore > building said target. > > The target will build fine under Visual Studio, using either normal build, > or IncrediBuild. However, executing the IncrediBuild via the commandline > via BuildConsole, like the build bots do, will manage to trigger this error > and likely cause link issues. It seems that IncrediBuild's guid validation > logic permits lowercase letters in the hex string, but then chokes on them > when using the guid to determine build targets. > > Here's a patch to gyp that will check for this specific error case so it > doesn't happen again: http://codereview.chromium.org/118021. But, incase > anyone else see strange skipped build target issues, try checking the GUID. > > -Albert > > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
