You may have realized that the try job status may now be green even if some tests failed. The reason is simple; http://since chromium-status.appspot.com/lkgr is only looking at some steps (namely unit_tests), it didn't make sense to blame the user for failed steps that may be red on the trunk. This is especially true from a presubmit check perspective.
References: See self.import_steps in: http://src.chromium.org/viewvc/chrome/trunk/tools/buildbot/scripts/master/try_job_status_update.py?view=markup See good_revision_steps in: http://src.chromium.org/viewvc/chrome/trunk/tools/buildbot/config/master.chromium/master.cfg?view=markup --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
