Or how about setting the default value of the theme in the Preferences file and loading it from there?
On Jun 9, 9:53 pm, Stefan Nuxoll <[email protected]> wrote: > How about a compile-time define instead? then it's a simple matter of > adding a -DTHEME_DLL my.dll > > > > > > On Tue, Jun 9, 2009 at 10:51 PM, Daniel Cowx<[email protected]> wrote: > > > Yeah, I could change the value in resource_bundle_win.cc and wrap it > > in a PP directive for my own build, but it becomes such a pain to > > maintain this over time (merging gets annoying). It would be easier if > > I didnt have to do this via a PP directive for my own build. > > > Question: > > Does anyone have objections to including a default param in the call > > to ResourceBundle::LoadThemeResources() that causes default.dll to be > > loaded by default? Alternatively, since default params are frowned > > upon, I could provide a wrapper function in ResourceBundle to > > accomplish the same end. > > > -Daniel > > > On Jun 9, 9:36 pm, dhhwai <[email protected]> wrote: > >> I think the answer is no for an official compile of Google Chrome. > >> The default.dll is hardcoded in app/resource_bundle_win.cc. > > >> But for your own compile, does changing the hardcoded value in app/ > >> resource_bundle_win.cc count as a solution? > > >> On Jun 9, 9:28 pm, Daniel Cowx <[email protected]> wrote: > > >> > ResourceBundle::LoadThemeResources() always loads default.dll from > >> > DIR_THEMES. Other than overriding DIR_THEMES via the PathService, is > >> > there another way to change the name of the DLL? > > -- > Stefan Nuxoll <[email protected]> --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
