Yes, it was my patch, it is completely my fault, I take all the blame.. I'm very sorry about that... The patch had been reviewed but through another revision that was mentioned in the comments... I should have put a link to it as opposed to only the revision ID (I'm used to internal tools that inserts the link automagically so I only put the rev number).
The problem is that after a merge conflict, I completely forgot to rebuild on Mac and Linux (which I have been doing regularly for over a month for this specific patch that has been opened forever and it wasn't trivial to do so) and so I broke the build last night (well, night in EDT). I quickly found the problem and fixed is and tried to build it on Linux but V8 didn't want to build after many re-sync and clobbers, I had not clue what was happening there, so I sent it to the try server and it built find, so I committed the re-landing... I know... I should not rely on the try server, but I have tried this patch many many times on all platforms and never had a problem... I tried again this morning and I had to create a whole new view of the repos to be able to properly build. The current problem is easy to fix, it is a last minute check that I added in platform independent code in reply to a code review suggestion and it didn't trigger on Windows (so I didn't see the error when I tested the platform independent code) and for some reason it started triggering on Linux after the last time I tried to run on Linux... It was a simply typo of an embedded for loop index that was causing a protective _DEBUG only DCHECK to fire... I could fix it easily this morning... But I'm not going to try this patch again soon, cause I noticed that it didn't completely solve the performance problem I was trying to solve... So I don't feel too good about it... (anybody has a *Harakiri* sword to spare? :-)... I'm very sorry that I caused so much trouble, and I will be much more careful next time... I'm hope you will all have a very good day anyway... :-) BYE SAD (the-developer-formerly-known-as-MAD :-) On Thu, Jun 11, 2009 at 7:30 AM, Dean McNamee <de...@chromium.org> wrote: > > Reoccuring lesson, when you're looking for a shotty change, look for > the ones with the worst commit messages: > > Of course I overlooked the change 50 times because the message tells > you absolutely nothing, doesn't have a review URL, etc. > > I don't feel like figuring out what is wrong with this patch, I will > TBR a revert right now. <Insert typical complaints about writing > Linux specific code, clearly not testing it at all, and wasting a > bunch of peoples time>. > > commit 7c4e9d282fb3af3ea5c732d37908a133662e02e2 > Author: m...@google.com <m...@google.com > @0039d316-1c4b-4281-b951-d872f2087c98> > Date: Thu Jun 11 01:08:27 2009 +0000 > > Relanding reverted patch 18090. > > > git-svn-id: svn://chrome-svn/chrome/trunk/s...@18130 > 0039d316-1c4b-4281-b951-d872f2087c98 > > > > On Thu, Jun 11, 2009 at 1:17 PM, Dean McNamee<de...@chromium.org> wrote: > > One of the ideas would be to bisect the archived builds > > (http://build.chromium.org/buildbot/continuous/linux/LATEST/). > > > > I am also working on hunting this down. I'll let you know when/if I > > find anything. > > > > Thanks for the great help > > -- dean > > > > On Thu, Jun 11, 2009 at 1:15 PM, Craig > > Schlenter<craig.schlen...@gmail.com> wrote: > >> > >> It might not be r18131 ... I compiled head without 18131 and even > >> though it looked like that helped earlier, it's broken again now. > >> Interestingly when opening new tabs, only some of them are broken > >> which is probably why I thought it was ok earlier ... will leave > >> something bisecting in the backround but it's a rather long cycle time > >> on my laptop to do each build. > >> > >> --Craig > >> > >> On Thu, Jun 11, 2009 at 12:42 PM, Craig > >> Schlenter<craig.schlen...@gmail.com> wrote: > >>> Hi Dean > >>> > >>> I am seeing the same thing ... it seems to be r18131 that is at fault. > >>> I have not tracked it down further than that ... > >>> > >>> Shared build is also bust. See attached patch ... dunno if that's the > right fix. > >>> > >>> --Craig > >>> > >>> On Thu, Jun 11, 2009 at 11:58 AM, Dean McNamee<de...@chromium.org> > wrote: > >>>> Something related to images, or resources, or decoders, or painting, > >>>> or something. Multiple reports of everything being complete broken. > >>>> > >>>> Screenshot of my recent build attached. > >>>> > >>>> -- dean > >>>> > >>>> >> > >>>> > >>> > >> > >> >> > >> > > > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
