-> chromium-dev On Thu, Jun 11, 2009 at 11:56 PM, Mark Larson<[email protected]> wrote: > > On Thu, Jun 11, 2009 at 20:46, Finnur Thorarinsson <[email protected] > > wrote: >> >> The presubmit check is now complaining if line endings on source files you >> add isn't set to LF. The message you get is: >> "Fix these files with svn svn:eol-style=LF" (and then lists the file(s)) >> I had to look up in the svn manual how to do this and then help someone >> else figure this out too. Combined we probably lost around half an hour >> trying to figure this >> out. So, for those who are/will be scratching their heads soon, this is the command: >> >> svn propset svn:eol-style LF <filename> >> >> I also would like to propose that we list this command in the error >> message, so we don't have to look this up every single time. > > Why not supplement your proposal with a patch? > http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/presubmit_canned_checks.py?view=markup > --Mark
On Fri, Jun 12, 2009 at 12:43 AM, Finnur Thorarinsson<[email protected]> wrote: > For starters, this file isn't in my tree. I could try to figure out how to > sync but I've been burned by this exact experience once before (some months > ago) and I ended giving up in frustration. > ... (blah blah blah) First, I'm glad the presubmit checks trapped you! :P Second, the (painful) depot_tools switch that occured a few weeks ago was *exactly* for this reason. Your depot_tools checkout *is a svn checkout* and you can hack and do the code review directly from there. So yes you have the file. If you have a http:// checkout (you can find it by using `svn info .` in depot_tools) you just need to do a corresponding `svn co svn://...` and replace your http:// checkout with the svn:// one. I had documented that earlier, did you read your emails? :) And yes it took me a minute to change http://codereview.chromium.org/126050 2009/6/12 Peter Kasting <[email protected]>: > BTW thanks to whomever wrote this presubmit check, it makes me very happy. > PK Thanks. Hopefully, the checks will stop the svn:eol-style inconsistency error messages. M-A --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
