I just submitted the change to remove _HAS_TR1 in vs2008.
   http://src.chromium.org/viewvc/chrome?view=rev&revision=19049

This should fix the vs2008 issues with gmock.  Let me know if you continue
to see problems.

-Albert


On Fri, Jun 19, 2009 at 5:23 PM, Albert J. Wong (王重傑)
<ajw...@chromium.org>wrote:

> If you didn't see my other mail to chromium-dev, I'll be trying to whack
> the tr1 dependency next week.  That should hopefully fix the issue you were
> having.  Will update this thread again when the patch is committed.
>
> -Albert
>
>
>
> On Mon, Jun 15, 2009 at 9:11 AM, Albert J. Wong (王重傑) <ajw...@chromium.org
> > wrote:
>
>>
>>
>> On Mon, Jun 15, 2009 at 9:03 AM, nakro <yoav.zilberb...@gmail.com> wrote:
>>
>>>
>>> Hi albret,
>>>
>>> projects that fail :
>>> gmockj
>>> gmockmain
>>>
>>> here is an example out from gmockmain
>>>
>>> C:\Program Files\Microsoft Visual Studio 9.0\VC\include\tuple(498) :
>>> error C2065: '_Is_swap_move' : undeclared identifier
>>> 1>        C:\Program Files\Microsoft Visual Studio 9.0\VC\include\tuple
>>> (504) : see reference to class template instantiation
>>>
>>> 'std::_Move_operation_category<std::tr1::tuple<_Arg0,_Arg1,_Arg2,_Arg3,_Arg4,_Arg5,_Arg6,_Arg7,_Arg8,_Arg9>>'
>>> being compiled
>>> 1>C:\Program Files\Microsoft Visual Studio 9.0\VC\include\tuple(499) :
>>> error C2226: syntax error : unexpected type
>>> 'std::_Move_operation_category<_Value>::_Move_cat'
>>> 1>C:\Program Files\Microsoft Visual Studio 9.0\VC\include\tuple(503) :
>>> error C2947: expecting '>' to terminate template-argument-list, found
>>> '>'
>>> 1>C:\Program Files\Microsoft Visual Studio 9.0\VC\include\tuple(503) :
>>> error C2976: 'std::_If' : too few template arguments
>>> 1>        C:\Program Files\Microsoft Visual Studio 9.0\VC\include
>>> \xutility(1018) : see declaration of 'std::_If'
>>>
>>> the solution on my machine is this
>>> to do HAS_TR1=0 (you have 1 by default)
>>> and to change
>>>
>>> gmock_port.h
>>>
>>> to include the boost version even on 2008, which initially your code
>>> goes to the <tuple> path
>>
>>
>> That's a good workaround.  Switching to the boost implementation would
>> almost certainly work for now.
>>
>> I'll attempt to reproduce and figure out a long term fix (including just
>> whacking the tr1 dependency out of gmock...started a discussion with
>> zhanyong about this last week).
>>
>> If it gets bad enough, we could consider changing over the VS2008 builds
>> to use boost as well, and then disable _HAS_TR1 as you described above, but
>> that'll require a full clobber from everyone due to precompiled header
>> issues.
>>
>> -Albert
>>
>>
>>
>>>
>>>
>>> but i must have something wrong with my machine if i am the only one
>>> who is having this
>>>
>>> >>>
>>>
>>
>

--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
    http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to