On Thu, Jun 25, 2009 at 5:27 AM, Dean McNamee <[email protected]> wrote:
> > I just took a look at what was happening on one of the Linux > buildbots. It looks like we completely clear the env and just > explicitly set a few things. We need to add LANG=en_US.UTF-8 to that > list of things. Any takers? I can add LANG to the list of whitelisted env var to keep. Would that work? Nicolas > > > Thanks > > On Thu, Jun 25, 2009 at 2:12 PM, Dean McNamee<[email protected]> wrote: > > > http://build.chromium.org/buildbot/waterfall/builders/Modules%20Linux%20(dbg)/builds/9486/steps/base_unittests/logs/stdio > > > http://build.chromium.org/buildbot/waterfall/builders/Modules%20Linux%20(dbg)/builds/9486/steps/net_unittests/logs/stdio > > > > I just committed a change that converted our > > sys_string_conversion_linux from using ICU UTF-8 (assuming that the > > system locale was always UTF-8) to calling the system APIs that will > > vary depending on the locale. I believe this is technically what we > > want, we want these APIs to do the conversion to whatever locale your > > system is set to. > > > > On my machine these all pass fine. I don't know what locale we have > > set on the buildbots, but it all seems to fail. It is also kind of > > curious that some of our net/file tests depend on locale, but I > > suppose that makes sense. > > > > For now I'll pull out my changes until we can get the buildbots on a > > utf-8 locale (like en_US.UTF-8). > > > > -- dean > > > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
