Chromiumites, who would be a good person to answer his question? :DG<
On Fri, Jul 3, 2009 at 1:47 AM, tvk<[email protected]> wrote: > > Hi, > > To fix issue #4576 how to get the page size? Fixing where would be > considered as the best? > > Below I elaborate the issue. > > In WebCore, HTML Select element is rendered using either > RenderMenuList or RenderListBox. RenderMenuList further uses > PopupListBox as a popup. When popup is visible, PageUp/PageDn are > working fine. Issue comes only when popup is closed. When popup is not > visible, SelectElement.cpp present in dom folder of WebCore handles > keyboard events and notifies its corresponding renderer. > > So the place where PageUp/PageDn events are handled knows only > renderer. Only renderer can tell the number of visible lines > considering current zoom level etc. Is it a good idea to ask renderer > from SelectElement.cpp to return number of visible items? > > In case of RenderMenuList, it has to ask PopupListBox under platform > chromium, and in the else part of this platform check we need to write > code that will get called by rest of Webkit users. But is it fine if > we decide what is correct for other users of Webkit? > > In case of RenderListBox, the method, numVisibleItems() that can > return number of visible items is a private method. Changing it to > public lets SelectElement.cpp to know the page size, but is it a good > thing to do? > > Please suggest. > > Thanks, > --- > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
