LGTM oh wait, where's the patch?
$ git grep 'undef LOG' -- '*.cc' | head -10 glue/alt_404_page_resource_fetcher.cc:#undef LOG glue/alt_error_page_resource_fetcher.cc:#undef LOG glue/autofill_form.cc:#undef LOG glue/back_forward_list_client_impl.cc:#undef LOG glue/chrome_client_impl.cc:#undef LOG glue/chromium_bridge_impl.cc:#undef LOG glue/context_menu_client_impl.cc:#undef LOG glue/devtools/debugger_agent_impl.cc:#undef LOG glue/devtools/debugger_agent_manager.cc:#undef LOG glue/devtools/devtools_rpc.cc:#undef LOG On Wed, Jul 8, 2009 at 5:46 AM, Dean McNamee<[email protected]> wrote: > > CXX /.../out/Debug/obj/webkit/glue/temporary_glue.o > In file included from ./base/timer.h:49, > from ./webkit/glue/resource_fetcher.h:19, > from ./webkit/glue/image_resource_fetcher.h:9, > from ./webkit/glue/webview_impl.h:16, > from webkit/glue/temporary_glue.cc:8: > ./base/logging.h:226:1: warning: "LOG" redefined > In file included from third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:24, > from third_party/WebKit/WebCore/history/BackForwardList.h:31, > from ./webkit/glue/back_forward_list_client_impl.h:8, > from ./webkit/glue/webview_impl.h:15, > from webkit/glue/temporary_glue.cc:8: > third_party/WebKit/JavaScriptCore/wtf/Assertions.h:230:1: warning: > this is the location of the previous definition > > Thanks > -- dean > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
