On Mon, Jul 13, 2009 at 1:44 PM, Aaron Boodman <[email protected]> wrote:
> > I'd like to close on some mumbling we've been doing about changes to > the page actions API. > > What: > > * Make it not required to pre-specify this icon list in the manifest. > This will require some refactoring to the utility process to be able > to use it to decode images at any time, not just install time. > * Rename enableForTab and disableForTab to show and hide > > Why: > > Increased awesomeness, shorter, more descriptive method names. Also it > seems like having a utility function lying around that can decode a > user-supplied image would be really useful for a variety of > applications in the future. > > Yay? Nay? > It seems reasonable, but I have some questions / concerns: - How/where are the resulting images cached? We don't want each request to have to be reencoded. In the current install model, they're simply encoded in place. - It seems like there may be related issues if multiple requesters ask for the image at the same time. - What's the increased latency for requesting a single image? I imagine it's not much, but at installation time, an extra 100ms would be no big deal, while in response to UI actions, it would be noticeable jank. - One benefit of having domain-specific image lists is that we could do other validation that was not just for security reasons. For example, we could enforce that page action images were of a particular size and not 2000x2000 (although I don't think we're doing this now). Erik --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
