Thanks for all of your help, it is much appreciated!
On 15 July, 12:39, PhistucK <[email protected]> wrote: > dev.chromium.org has a lot of info ("Getting around the source code" is an > example).But in your case, you want it to start up without switches, you > just want it to be your version from the beginning with no special attention > (besides compiling). > > You cannot exactly 'upload the changes back to the Google servers', you can > submit a patch that will incorporate your changes (little changes, do not > bring up all of the changes because people review these patches), there is > an explanation about this in dev.chromium.org too. > One (or more) of the committers review your changes and if the changes were > approved, they commit the change list (=patch). > > Before submitting a patch, you should first ask if this is possible, because > maybe they are not ready for supporting multiple (external) branches yet. > > SVN should be fine about the changes, anyway, unless there are real > conflicts. > Just run "gclient sync" and everything will be fine (and if not, it will > notify you with a confirmation and some options). > > About the switches, you can simply reverse the switch (with ! in the > condition). But that will also give you the incognito features, which I am > not sure you would really like to have. > > ☆PhistucK > > > > On Wed, Jul 15, 2009 at 13:33, Kruncher <[email protected]> wrote: > > > I wasn't aware that SVN manages changes within the content of a file. > > I am relatively new to open source code, and have only ever used SVN > > to download the Chromium trunk. I also did not realize that it was > > possible to upload changes back to the Google servers. > > > I will have to read up on how SVN works. Perhaps there is a reserved > > comment/macro that can be used to protect a range of code. > > > Across several of the projects there appears to be an interface which > > is responsible for constructing the required browser based upon > > command switches. This interface is able to switch between starting up > > with the standard and incognito windows, so I thought perhaps there > > would be a way to override this. > > > Do you know of any documentation which explains the architecture of > > Chromium, and the purpose of the various projects and files? > > > On 15 July, 10:41, PhistucK <[email protected]> wrote: > > > SVN usually manages to merge the changes you have made with the changes > > from > > > trunk, unless they have changed that same bit of code you have and then, > > it > > > says there is a conflict and lets you look at the differences. I modified > > > things in the actual Chromium source, not in a new project. > > > > There was a thread about creating branches and they said it is better > > > handled with GIT, though I have never used GIT and since almost all of my > > > changes were only adding things\the code nearby the code I changes were > > not > > > changed, no conflicts occurred. > > > > If your changes can be incorporated into the code because most of what > > they > > > do is removing options, maybe you can even upload your changes to the > > > Chromium source code (with #IF DEFINE YOUR_CUSTOM_CODE or something). But > > > you have to ask them first, of course. > > > > ☆PhistucK > > > > On Wed, Jul 15, 2009 at 11:41, Kruncher <[email protected]> wrote: > > > > > Thanks for your fast reply! > > > > > When you made your changes, did you start with a new project, or did > > > > you edit the Chromium browser itself? > > > > > I was considering just modifying the browser. My concern was that if I > > > > wanted to update the Chromium trunk, I would need to redo my various > > > > changes to the system. > > > > > Thanks again, > > > > > On 15 July, 09:31, PhistucK <[email protected]> wrote: > > > > > It is actually pretty easy to do that, I guess.I changed chromium to > > > > support > > > > > another button in the toolbar with a keyboard shortcut and removed > > the > > > > > "About Chromium" menu really easily - and my knowledge in C++ is > > nearly > > > > > nonexistent (I only know the syntax since it is similar to > > JavaScript). > > > > > > You should look at the code that uses the regular window and the code > > > > that > > > > > uses the incognito window (use the theme GRD files for hints to what > > to > > > > > search for, like the Incognito logo and its ID) and compare the two, > > move > > > > > the things that fit you from incognito back into the regular window. > > > > > The debugger and everything, you can leave them in the code, simply > > > > remove > > > > > all of the reference to them, like menu items (pretty easy to find), > > > > > keyboard shortcuts and context menu items. > > > > > > ☆PhistucK > > > > > > On Wed, Jul 15, 2009 at 10:50, Kruncher <[email protected]> wrote: > > > > > > > Hi, > > > > > > > I would like to create a custom browser application based on the > > > > > > Chromium source. I have downloaded and compiled the source (from > > the > > > > > > "Chrome.sln" solution. > > > > > > > What I want to do is: > > > > > > - Create a new executable project. > > > > > > - Create a custom view that is similar to the "Incognito" view. I > > > > > > would like the browser to start in this view when opened. > > > > > > > However, I do not want/need to include the regular or "Incognito" > > > > > > views, and I want to strip out all of the JavaScript/DOM debugging > > > > > > parts. > > > > > > > I would really appreciate it if someone could give me some > > guidelines. > > > > > > I have had a read through some of the sources, and I have a rough > > idea > > > > > > as to how the projects are structured. > > > > > > > Many thanks, > > > > > > Lea Hayes --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
