On Wed, Jul 22, 2009 at 10:07 AM, Darin Fisher <[email protected]> wrote:
> On Wed, Jul 22, 2009 at 10:03 AM, Adam Langley <[email protected]> wrote: > >> * By having the ChangeLog in the review, reviewers can critique it. >> > >> Many of our commit messages are little brief. Some are far too brief. >> But, the commit message should match the change message on the code >> review, so our reviewers can already critique it. So, this would >> appear to be a review issue rather than a technological issue. >> > > I think we need to remember to review the CL description. It is easy to > overlook when reviewing an issue. > This is an understatement. We really do a poor job with commit descriptions. There is a lot to be gained by having better commit descriptions. We can learn from WebKit process here without adding the burden of ChangeLog files. They have great change descriptions and it's frequently very useful. To be a bit more concrete, gcl change could autopopulate your change description with something like the following that has the list of modified functions: DETAILED DESCRIPTION HERE BUG=required TEST=required RELEASE_NOTES=optional Autogenerated list of modified methods here. So here's what an example would look like (poached from AGL's recent webkit commit): Chromium Linux: Allow for setting the global font rendering preferences. Added static functions for setting hinting, anti-alias and subpixel glyph preferences. BUG=12345 TEST=none RELEASE_NOTES=none platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setHinting): (WebCore::FontPlatformData::setAntiAlias): (WebCore::FontPlatformData::setSubpixelGlyphs): (WebCore::FontPlatformData::setupPaint): Modified to do something super special. platform/graphics/chromium/FontPlatformDataLinux.h: Ojan --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
