On Thu, Jul 23, 2009 at 4:54 PM, Evan Martin<[email protected]> wrote: > On Thu, Jul 23, 2009 at 4:50 PM, Ben Laurie<[email protected]> wrote: >> >> On Thu, Jul 23, 2009 at 4:44 PM, Darin Fisher<[email protected]> wrote: >>> On Thu, Jul 23, 2009 at 4:42 PM, Ben Laurie <[email protected]> wrote: >>>> >>>> On Thu, Jul 23, 2009 at 4:30 PM, Wan-Teh Chang<[email protected]> wrote: >>>> > Ben, >>>> > >>>> > I believe the GCC warning you want is -Wreturn-type, which is enabled >>>> > if we specify -Wall: >>>> > >>>> > http://gcc.gnu.org/onlinedocs/gcc-4.3.3/gcc/Warning-Options.html#Warning-Options >>>> > >>>> > Are we not compiling with -Wall? >>>> >>>> Apparently not, which is surprising. -Werror would seem like a good >>>> idea, too, though I have not tried it to see how much fixing would be >>>> needed. >>> >>> What file had the error? (Not all code is compiled with the same warning >>> level.) >> >> This was a new file of my own, it lives in src/webkit. > > Files that tweak -Wall: > > % git grep -l -e 'Wall' -- '*.gyp*' > build/common.gypi > build/external_code.gypi > > From those it appears you need a given .gyp file to opt in to -Wall, > by marking it as "Chromium code". > > % git grep -l chromium_code -- '*.gyp' > app/app.gyp > base/base.gyp > build/temp_gyp/googleurl.gyp > chrome/app/locales/locales.gyp > chrome/chrome.gyp > chrome/test/security_tests/security_tests.gyp > courgette/courgette.gyp > gears/gears.gyp > media/media.gyp > net/net.gyp > net/tools/tld_cleanup/tld_cleanup.gyp > o3d/breakpad/breakpad.gyp > o3d/build/nacl.gyp > o3d/compiler/technique/technique.gyp > o3d/converter/converter.gyp > o3d/core/core.gyp > o3d/import/archive.gyp > o3d/import/import.gyp > o3d/plugin/idl/idl.gyp > o3d/plugin/plugin.gyp > o3d/serializer/serializer.gyp > o3d/statsreport/statsreport.gyp > o3d/tests/tests.gyp > o3d/utils/utils.gyp > printing/printing.gyp > sdch/sdch.gyp > views/views.gyp > webkit/activex_shim/activex_shim.gyp > webkit/activex_shim_dll/activex_shim_dll.gyp > webkit/tools/test_shell/test_shell.gyp > > We could probably do better in webkit.gyp.
Not surprisingly, adding that to webkit.gyp breaks things :-) I could look at a patch for that if people think its wise. --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
