I should have brought this up earlier, but is there a reason we're disabling it at compile time rather than just putting it behind a run-time flag? The benefit of the latter is that people can play with it if they want (even though it's half-baked) and people will see if their change breaks it (since it's getting compiled in by default).
J On Fri, Jul 24, 2009 at 11:22 AM, Jens Alfke <[email protected]> wrote: > > I just submitted r21551, which simply turns off ENABLE(DATAGRID) in > WebCore. This CL produced build errors on the Linux and Windows try > bots until I told them to --clobber; then it succeeded. Could be > something to do with stale generated V8 bindings. > > So there's a chance that your local build might fail for similar > reasons. If it does, try deleting the V8 generated bindings and > rebuilding. (Touching the V8 code-generator .pm file should be enough > to force the bindings to get rebuilt on the next build.) > > —Jens > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
